Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncgopher fails to build after update to rust-1.54 #35

Closed
0323pin opened this issue Sep 13, 2021 · 3 comments
Closed

ncgopher fails to build after update to rust-1.54 #35

0323pin opened this issue Sep 13, 2021 · 3 comments

Comments

@0323pin
Copy link

0323pin commented Sep 13, 2021

Hi,

I'm the NetBSD package maintainer for ncgopher, it no longer builds on NetBSD after updating to rust-1.54.0

  • OS: NetBSD
  • Version: current, rolling
  • Rust: 1.54.0

This week Rust was updated from 1.52.1 to 1.54.0
After this update, two independent builds have reported that ncgopher fails to build.
While we were using 1.52.1, the package always built fine and no changes to the package were done during this time.

Please find a build reports here, https://us-east.manta.joyent.com/pkgsrc/public/reports/NetBSD/trunk/x86_64/20210911.1245/ncgopher-0.2.0nb1/build.log and here, http://www.ki.nu/pkgsrc/reports/current/NetBSD-9.0/20210911.0116/ncgopher-0.2.0nb1/build.log

Don't know if you can do much about it as the error seams to be on lexical-core but, thought I'd let you know.

Regards

EDIT: see, Alexhuszagh/rust-lexical#55
It might be enough to update lexical-core.

EDIT2: cargo tree outputs the following, https://pastebin.com/QE5qyy3p
More than one entry for lexical-core, maybe better to bump all dependencies and get things up-to-speed.

@Johann150
Copy link
Collaborator

Johann150 commented Sep 13, 2021

I could not reproduce this issue with neither Rust 1.54.0 nor the latest stable on Linux (i.e. 1.55.0, rustup toolchain stable-x86_64-unknown-linux-gnu).

I updated the dependencies in 2b4f666 (it's just running cargo update).

@0323pin
Copy link
Author

0323pin commented Sep 13, 2021

I updated the dependencies in 2b4f666

Thanks

it's just running cargo update

No, not for packaging. We need a release tag to pull the source for the package build, pulling from a commit can cause breakage in the future.

@0323pin
Copy link
Author

0323pin commented Sep 13, 2021

@Johann150 I've just built ncgopher from 2b4f666 and it compleated successfully.
I'll bump the package revison and merge the build from this single commit, better to do this over providing a broken package with the stable release. Thanks!

@0323pin 0323pin closed this as completed Sep 13, 2021
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Sep 13, 2021
Both mef and jperkin have reported broken builds for ncgopher
after rust update to 1.54.0

I've contacted upstream and they have updated the dependencies
but, no new release.
jansc/ncgopher#35

The package builds fine on my 9.99.88 amd64 now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants