Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

make travis not waste its own and everyone’s time #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flying-sheep
Copy link
Contributor

because failing after making that poor machine do all that stuff isn’t nice

@japaric
Copy link
Contributor

japaric commented Jan 4, 2015

As you may have notice all the test scripts run, even if some of them fail, so running the check-line.sh first doesn't change the outcome.

@flying-sheep
Copy link
Contributor Author

didn’t notice that. is there a way to suppress that?

@japaric
Copy link
Contributor

japaric commented Jan 4, 2015

we could chain the commands with &&, but ... if you put the line-check first and it fails, the test ends and you won't see if cargo build/test passed because they didn't run.

@flying-sheep
Copy link
Contributor Author

well, since the line check obviously is in place to prevent inadequately-styled code to be pulled, this is what you want, isn’t it?

if it isn’t, putting it first at least allows people to immediately see that checks fail, before even the build starts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants