Lower Profile Changes to make Crate and Examples build with Rust 1.44 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This locally ignores deprecation warnings for digital::v1 I/Os for making crate and examples build with Rust 1.44. Pull request japaric#109 already moved to another STM32F3 HAL to solve this issue. So this just makes the code compile whitout running into fatal warnings.
Let's have our explicit dependencies on the same versions as crates already pulled in by implicit ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109 switches to another STM32F3 HAL to solve the current issues when building with Rust 1.44. These are breaking changes delaying the integration.
What about some smaller dependecy updates and hot fixing the deprecation warnings for getting the great examples from this create up and running again as a minor update? This would also solve #110.
I did not update the crate version and would leave this up to you @japaric.