Fixes for the previously merged TryFrom
#10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @regexident I think you may need to install the rustfmt-preview in the Travis builder for the buld script to work, though? Let's see what bors says. bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 2, 2018
10: Fixes for the previously merged `TryFrom` r=japaric a=regexident Turns out generating shim code via `build.rs` and relying on being correct without compiling/running any of it during testing is a bad idea. Code that does not get compiled won't fail tests either. Embarrassing. Fixes: - I used `#[cfg(feature = “try_from”)]` instead `#[cfg(feature = “try-from”)]` causing my code to not even get generated. (#fdda4b1) - Had a wrong error type in one function that did not get caught. (#07319d7) - Had a wrong implementation in one function that did not get caught. (#e3d0328) Changes: - Switched errors from `core::num::TryFromIntError` to `cast::Error`. (#35a3fbd) - Removed impls of `TryFrom` for `usize`/`isize` to mirror ‘stdlib’. (#67a17b1) - Refactored unit tests. Let’s actually run them this time, shall we? (#b134161) As part of the unit test refactoring we are now also: - Testing `From` and `TryFrom` for every variant of `cast::From`, where applicable. - Splitting asserts into smaller test functions making it easier to see what's wrong. We now have **418 tests** for `num-traits` and **477 tests** for `cast::From`/`From`/`TryFrom`.
Build failed |
|
|
Could we try this one again, @japaric? |
|
Any chance to have this re-tested and merged, @japaric? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out generating shim code via
build.rsand relying on being correct without compiling/running any of it during testing is a bad idea. Code that does not get compiled won't fail tests either. Embarrassing.Fixes:
#[cfg(feature = “try_from”)]instead#[cfg(feature = “try-from”)]causing my code to not even get generated. (#fdda4b1)Changes:
core::num::TryFromIntErrortocast::Error. (#35a3fbd)TryFromforusize/isizeto mirror ‘stdlib’. (#67a17b1)As part of the unit test refactoring we are now also:
FromandTryFromfor every variant ofcast::From, where applicable.We now have 418 tests for
num-traitsand 477 tests forcast::From/From/TryFrom.