Require toml extra for setuptools_scm #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools_scm does not know to invoke itself
if it can't read pyproject.toml. This broke
sdist installs for projects deriving from skeleton:
$ python -m pip install zipp --no-binary zipp
Collecting zipp
[...]
Successfully installed zipp-0.0.0
Note the version number defaulting to '0.0.0'.
Building locally only works because pep517,
the build tool, depends on toml which it exposes
to the build environment.
A bare [tool.setuptools_scm] does not work in 3.4.0.
|
Running |
This was referenced Jan 22, 2020
|
Oh, dear! I had forgotten to include that extra. Thanks for this. (Squashing to limit noise in the skeleton). |
This was referenced Jan 23, 2020
Closed
This was referenced Mar 4, 2020
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 12, 2020
v3.1.0 ====== #47: ``.open`` now raises ``FileNotFoundError`` and ``IsADirectoryError`` when appropriate. v3.0.0 ====== #44: Merge with v1.2.0. v1.2.0 ====== #44: ``zipp.Path.open()`` now supports a compatible signature as ``pathlib.Path.open()``, accepting text (default) or binary modes and soliciting keyword parameters passed through to ``io.TextIOWrapper`` (encoding, newline, etc). The stream is opened in text-mode by default now. ``open`` no longer accepts ``pwd`` as a positional argument and does not accept the ``force_zip64`` parameter at all. This change is a backward-incompatible change for that single function. v2.2.1 ====== #43: Merge with v1.1.1. v1.1.1 ====== #43: Restored performance of implicit dir computation. v2.2.0 ====== #36: Rebuild package with minimum Python version declared both in package metadata and in the python tag. v2.1.0 ====== #32: Merge with v1.1.0. v1.1.0 ====== #32: For read-only zip files, complexity of ``.exists`` and ``joinpath`` is now constant time instead of ``O(n)``, preventing quadratic time in common use-cases and rendering large zip files unusable for Path. Big thanks to Benjy Weinberger for the bug report and contributed fix (#33). v2.0.1 ====== #30: Corrected version inference (from jaraco/skeleton#12). v2.0.0 ====== Require Python 3.6 or later.
This was referenced Mar 15, 2020
This was referenced May 13, 2020
This was referenced Jun 1, 2020
This was referenced Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools_scm does not know to invoke itself
if it can't read pyproject.toml. This broke
sdist installs for projects deriving from skeleton:
Note the version number defaulting to '0.0.0'.
Building locally only works because pep517,
the build tool, depends on toml which it exposes
to the build environment.