Merge pull request #113 from jaraco/feature/glob-perf

Improve glob performance
jaraco · Mar 13, 2024 · 48b72b8 · 48b72b8
2 parents 4cceb49 + 171fa98
commit 48b72b8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/newsfragments/106.feature.rst b/newsfragments/106.feature.rst
@@ -0,0 +1 @@
+Bypass ZipFile.namelist in glob for better performance.
diff --git a/tests/test_complexity.py b/tests/test_complexity.py
@@ -85,7 +85,7 @@ def test_glob_depth(self):
             max_n=100,
             min_n=1,
         )
-        assert best <= big_o.complexities.Quadratic
+        assert best <= big_o.complexities.Linear
 
     @pytest.mark.flaky
     def test_glob_width(self):

diff --git a/zipp/__init__.py b/zipp/__init__.py
@@ -402,7 +402,8 @@ def glob(self, pattern):
         prefix = re.escape(self.at)
         tr = Translator(seps='/')
         matches = re.compile(prefix + tr.translate(pattern)).fullmatch
-        return map(self._next, filter(matches, self.root.namelist()))
+        names = (data.filename for data in self.root.filelist)
+        return map(self._next, filter(matches, names))
 
     def rglob(self, pattern):
         return self.glob(f'**/{pattern}')