Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unexpected character \ufeff #125

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Aug 27, 2024

The comment line somehow had unexpected unicode character added by ff0b75e. Found via https://phabricator.services.mozilla.com/D220347#C8303474NL332

@jaraco
Copy link
Owner

jaraco commented Sep 9, 2024

Neato. Invisible characters.

Is there any chance this issue would have security consequences? It's kind-of a shame that GitHub doesn't make the diff visible. I still don't know where the character appears.

I suspect that commit was cherry-picked from CPython, so the same issue probably exists(ed) there.

@jaraco jaraco closed this Sep 9, 2024
@jaraco jaraco reopened this Sep 9, 2024
@saschanaz
Copy link
Contributor Author

I think that character is fine, it's just zero width joiner.

@jaraco
Copy link
Owner

jaraco commented Sep 9, 2024

I think I agree. I still worry about the impact these unintended changes have, so I've reached out to the original contributor in the linked commit. I've also filed an issue with ruff to consider checking for these changes to flag them sooner than later. Catching them two layers downstream is really painful to mitigate.

@jaraco jaraco merged commit b8a63ca into jaraco:main Sep 9, 2024
16 of 28 checks passed
@saschanaz saschanaz deleted the patch-1 branch September 9, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants