Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of things to update and modernize the Meson setup. It would also be good to set a minimum Meson version in your
project
call, as there are other things that could be done, but I wasn't sure if it would be too new.It is recommended to not use (enable|disable) prefix on option names, as this is not autoconf.
dependency
, notfind_library
.dl
andm
are glibc-specific, and should be optional in order to build on other systems.cpp_std
as a build option, useinclude_directories
, and enable hidden symbol visibility again.I would also say you should explicitly list out the files instead of using
find
, but you do that so much I didn't want to do that out of the blue.