Fix for Object-like data without hasOwnProperty #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2138 From time to time, Formik may be passed Object-like data that does not inherit from the Object prototype. In these cases, hasOwnProperty is not defined, and prepareDataForValidation will throw. The fix is to use Object.prototype to call hasOwnProperty on the data. See urql-graphql/urql#343
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 888744e:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2138
From time to time, Formik may be passed Object-like
data that does not inherit from the Object prototype.
In these cases, hasOwnProperty is not defined, and
prepareDataForValidation will throw.
The fix is to use Object.prototype to call
hasOwnProperty on the data.
See urql-graphql/urql#343