Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging #268

Closed
jaredpalmer opened this issue May 18, 2017 · 9 comments
Closed

Better logging #268

jaredpalmer opened this issue May 18, 2017 · 9 comments

Comments

@jaredpalmer
Copy link
Owner

jaredpalmer commented May 18, 2017

Really want improve logging. Seems like it is inevitable that we drop react-dev-utils/formatWebpackMessages and use a custom formatter. This would allow us to have one call to

const multiCompilers = compile([serverConfig, clientConfig])

In multi-compiler mode, we can still pass the respective clientCompiler to webpack-dev-server and watch the serverCompiler in pretty much the same way. However, we would then be able to write truly universal logger (which would look a lot like formatWebpackMessages, but handle multiple configs).

@jaredpalmer
Copy link
Owner Author

Going to post some screenshots of my ideas.

@jaredpalmer
Copy link
Owner Author

Razzle Loading/Compiling ... (probably powered by Ora)

razzle_loading_cli

Razzle Errors pipe below:
razzle_error_cli

@jaredpalmer jaredpalmer changed the title New logger / error formatter Better logging Jun 1, 2017
@jariz
Copy link
Collaborator

jariz commented Aug 28, 2017

@jaredpalmer Did you already start on this?
Sounds like a fun issue to tackle!

@jaredpalmer
Copy link
Owner Author

Nope. Go for it!

I was talking to Sean Larkin at React Rally about Webpack and unfortunately there is literally zero way to tell if the errors are identical or not. So despite the current logger, we really should be showing both at all times.

@jariz
Copy link
Collaborator

jariz commented Dec 20, 2017

hey @jaredpalmer, I think my PR was a bit too crazy and unstable regarding the UI side of things, but I still really liked the multicompiler approach and the general direction it was going.
It made for a single compiler rather than 2 instances (more clear codebase and probably better for performance) and it would also show an error overlay when a server side compile would fail, which - I thought - was really cool.

Also the UI side of things could be toned down a bit with a less intrusive approach like just clearing the console whenever the server/client bundle becomes invalid, rather than having them display at all times like my PR had.

Let me hear what you think!

@jaredpalmer
Copy link
Owner Author

I’d be open to exploring it. How does multicompiler deal with the making the hashed names client assets available to the server? Is there a plug-in?

@jariz
Copy link
Collaborator

jariz commented Dec 20, 2017

It 'solves' it be concatting the hashes together. I modified the webpack client to only grab the first part because it would attempt to accept server side HMR's otherwise.

@stale
Copy link

stale bot commented Aug 15, 2018

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

@stale stale bot added the stale label Aug 15, 2018
@stale
Copy link

stale bot commented Aug 22, 2018

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.

@stale stale bot closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants