feat(razzle): add Yarn PnP support

[merceyz]

What's the problem this PR addresses?

razzle doesn't work with Yarn PnP due to missing dependencies and incorrect assumptions about the node_modules layout.

ref #896

How did you fix it?

• Add undeclared dependencies
• require.resolve things that the user isn't responsible for providing
• Resolve plugins relative to the config
• Add https://github.com/arcanis/pnp-webpack-plugin (only PnP specific thing)

Notes
This only adds PnP support to razzle, the various plugins haven't been fixed as some of them require upstream changes

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jared/razzle/7cyafnksh
✅ Preview: https://razzle-git-fork-merceyz-pnp.jared.vercel.app

[fivethreeo]

Great work, but. Can you do this against the next-awesome branch?

[fivethreeo]

Also, don't format the code. Makes it easier to see the changes. :)

[merceyz]

These changes (except the PnP plugin) are bugfixes that should go out in the current release. Based on #1377 next-awesome is going to use webpack 5 which doesn't need the plugin which just leaves bugfixes.

Also, don't format the code. Makes it easier to see the changes. :)

Reverted, but master should probably be formatted then so contributors can make sure their PR is consistent easily

[benkingcode]

Isn't the code formatted on commit? Prettier is listed in lint-staged

[merceyz]

The pattern wasn't matching anything, fixed.
You can cherry-pick that commit into master and run the format so I can rebase and re-run the format on my changes

[fivethreeo]

Next-awesome will support both webpack 4 and 5. I will do a 3.2 off next-awesome before 4.0 without webpack 5. Then add wepback 5 support and some breakIng changes. So I don’t have to keep two brances in sync.

Strange, pre commit hook does not run for me.

[fivethreeo]

But I can lint master 😀

[merceyz]

Strange, pre commit hook does not run for me.

It runs for me but it doesn't match any files, with 0eea6ab it matches correctly

[fivethreeo]

Hm, github desktop does not run pre-commit. But I wont add pnp to master now. It must go in next-awesome.

[fivethreeo]

#1400

[merceyz]

I was going to do it just haven't had the time yet, but it's fine, will you add me as a co-author before you merge it?
I'll close this

[fivethreeo]

I will :)

…

On Thu, 27 Aug 2020 at 21:33, Kristoffer K. ***@***.***> wrote: Closed #1398 <#1398>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1398 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAADGQMXAYNSVJP4ZNJ6ELSC2YGZANCNFSM4QK5566Q> .

-- Øyvind Saltvik

[fivethreeo]

What kind of changes are needed that require upstream changes for plugins?

[merceyz]

When I tested the typescript plugin the upstream dependencies have undeclared dependencies so that needs to be fixed, otherwise it probably works