WIP: Improve monorepo support

[natemoo-re]

Related to #122. Feedback welcome!

Goals

• Simplify integration of new templates
  • Remove hardcoded template references in src/index.ts
• Introduce project structures (basic, monorepo)
• Prompt tsdx create users to select project structure (if template supports it)
• Automatically determine if a template supports monorepo structure
  • basic template and monorepo template must share a basename
  • monorepo template should be suffixed with -monorepo

Ideas

• Allow tsdx create (or new command?) to scaffold out a new package within an existing monorepo
  • How to determine if run inside a monorepo, where to place package?

[aleclarson]

How to determine if run inside a monorepo, where to place package?

Maybe by finding all directories with a package.json and prompting the CLI user to choose between their parent directories? The other route is supporting only Lerna and Yarn workspaces, and checking their configuration.

[natemoo-re]

Both good ideas.

As of right now, this PR adds lerna to any monorepo created with tsdx create. Yarn workspaces are great, but using lerna avoids forcing any package manager lock-in.

If that remains the case, I'd lean towards checking lerna.json packages and prompting the CLI user to select one (if there are multiple.)

[natemoo-re]

The current react template includes a playground at /mylib/example. For the react-monorepo template, should the playground be moved to /examples/basic? This seems like a common pattern (see jest, storybook, next.js).

[swyxio]

no opinion, go for it :)

[natemoo-re]

I'll be circling back to this shortly. Does cutting off this PR at adding basic-monorepo and react-monorepo templates sound okay for a first pass?

I'd like to add support for tsdx create within existing monorepos, but I think that can be split out into a separate issue to keep things moving.

[swyxio]

circling back. still keen on this? i dont monorepo, personally. @NateRadebaugh might care for #188

[NateRadebaugh]

Yes I would love to switch my monorepo to use tsdx at the root. It looks like this threat is talking about scaffolding a new project, so https://github.com/natemoo-re/tsdx-monorepo may be enough of an example for my use case.

[natemoo-re]

@sw-yx Yes, I'd love to finish this up now that some personal stuff has settled down. Thanks for the reminder! 😄 I'll see what it takes to get this up to date.

If @NateRadebaugh lands some docs to close #188, I would be happy to add a section for monorepos

[jaredpalmer]

What's the status of this?

[jaredpalmer]

Skimmed over it.

[jaredpalmer]

Remove this file. We are on #TeamYarn

[jaredpalmer]

What about test and lint cmd?

[natemoo-re]

Sorry for clogging up your PRs. I’m going to close this and reopen if I find time to finish it. If anyone wants to use this as a starting point for their own implementation, please do.