Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): parse tsconfig extends, trailing commas, and comments #489

Merged
merged 1 commit into from
Mar 10, 2020

Commits on Mar 10, 2020

  1. (fix): parse tsconfig extends, trailing commas, and comments

    - use ts.readConfigFile to properly parse a commas and comments from
      tsconfig instead of just trying to readJSON
    - use ts.parseJsonConfigFileContent to properly parse `extends` and
      get recursive compilerOptions
    
    - add tests for all of the above use cases
      - add them to build-withTsconfig which changes declarationDir;
        should only work if TSDX properly parses the tsconfig
    
    NOTE: this is only necessary for internal, TSDX-specific parsing of
    tsconfig.json. rollup-plugin-typescript2 already handles these options,
    but internal options like esModuleInterop etc are also used & parsed
    independently of rpts2
    agilgur5 committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f2ae526 View commit details
    Browse the repository at this point in the history