multi-entry: temporarily change docs to singular "module" #862
Conversation
I spent ten minutes with adding globs and comma-separated paths before giving up going into the issues and searching/finding jaredpalmer#175 / jaredpalmer#367. Maybe delete the `(s)` until the issue is resolved to prevent other people from doing the same. :)
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/kq6i13w1b |
agilgur5
changed the title
There was a problem hiding this comment.
Agreed, I fell victim to the same problem then dug into the code and wrote #367 (which was like my second or third PR as a contributor), hopefully this helps a bit.
The API docs are supposed to be equivalent to the --help of each subcommand, so you'll need to modify the help text for both build and watch too:
https://github.com/formium/tsdx/blob/d4c3bb220bba4ab26545b9d1a09ef646f031bc63/src/index.ts#L366
agilgur5
added
the
scope: docs
|
Done, I simply used the "edit"-buttons in GitHub, guess you can squash when you merge? |
|
@allcontributors please add @KATT for docs |
|
I've put up a pull request to add @KATT! 🎉 |
…r#862) - multi-entry is not currently supported due to a bug, PR to fix has yet to be merged - so modify docs that suggest it is supported from plural "Entry module(s)" to singular I spent ten minutes with adding globs and comma-separated paths before giving up going into the issues and searching/finding the bug and PR to fix the bug Maybe delete the `(s)` until the issue is resolved to prevent other people from doing the same. :)
I spent ten minutes with adding globs and comma-separated paths before giving up going into the issues and searching/finding #175 / #367.
Maybe delete the
(s)until the issue is resolved to prevent other people from doing the same. :)