Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jaredpar committed Jan 30, 2020
1 parent 5184394 commit e115509
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion eng/common/templates/job/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ parameters:
container: '' # required -- name of the container
osGroup: '' # required -- operating system for the job
extraSetupParameters: '' # optional -- extra arguments to pass to the setup script
frameworks: ['netcoreapp3.1'] # optional -- list of frameworks to run against
frameworks: ['netcoreapp3.0'] # optional -- list of frameworks to run against
continueOnError: 'false' # optional -- determines whether to continue the build if the step errors
dependsOn: '' # optional -- dependencies of the job
timeoutInMinutes: 320 # optional -- timeout for the job
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
using Roslyn.Test.Utilities;
using Xunit;

// The ShadowCopyAnalyzerAssemblyLoader type is only defined for the below platforms
#if NET472 || NETCOREAPP3_1

namespace Microsoft.CodeAnalysis.UnitTests
{
public sealed class ShadowCopyAnalyzerAssemblyLoaderTests : TestBase
Expand Down Expand Up @@ -99,7 +96,3 @@ public sealed class TestAnalyzer : AbstractTestAnalyzer
}
}
}

#else
#error unsupported configuration
#endif

0 comments on commit e115509

Please sign in to comment.