-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added async deserialize/serialize function types #349
Added async deserialize/serialize function types #349
Conversation
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1113 1113
=========================================
Hits 1113 1113 Continue to review full report at Codecov.
|
@jaredwray FYI, this change is breaking the Apollo server keyv adapter (v1.1.0) The types returned by 'serialize(...)' are incompatible between these types.
Type 'string | Promise<string>' is not assignable to type 'string'.
Type 'Promise<string>' is not assignable to type 'string'. |
@kaioduarte - thanks for bringing this to our attention. Do you know what the recommended fix is? If not, I can dig in later this week to figure out what is the difference. |
@jaredwray, I'm not sure what would be the proper fix. This issue is happening when you have keyv@^4.3.1 and @apollo/util.keyv-adapter@1.1.0 (which has I can create a PR to bump keyv version for the adapter, but it won't work if people have the adapter version fixed to 1.1.0. |
@kaioduarte - we have a fix that should go out for |
@jaredwray amazing, thank you! |
@kaioduarte - if you have any questions please create an |
Added
Promise
d return types forserialize
anddeserialize
.