Reintroduce getMany optional method
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace (jaredwray#362)" (jaredwray#365)" This reverts commit da05c2f.
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1113 1113
=========================================
Hits 1113 1113 Continue to review full report at Codecov.
|
|
@trevor-scheer - it looks like this definition was rolled back because it broke other clients. |
|
@jaredwray i asked to have this reverted originally because the typing was incorrect on the original PR and it wasn't ready to be merged in the first place. Where is there a report of broken clients? This is marked as optional so shouldn't be a breaking change unless the types are wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstates #362
The
undefined | undefinedtype was happening viaxo's fix option due to a lint config which forbids the use ofnull(and converts toundefined(@typescript-eslint/ban-types). In hindsight, I'm not sure thenullwas correct there to begin with.