Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed redis issue #406

Merged
merged 2 commits into from
Jul 14, 2022
Merged

fixed redis issue #406

merged 2 commits into from
Jul 14, 2022

Conversation

jaytist
Copy link
Contributor

@jaytist jaytist commented Jul 13, 2022

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix for Redis.Cluster support is broken as of v2.3.6 #385

  • What is the current behavior? (You can also link to an open issue here)
    NA

  • What is the new behavior (if this is a feature change)?
    NA

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    NO

  • Other information:

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #406 (8e7548e) into main (daa9079) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #406   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1113      1118    +5     
=========================================
+ Hits          1113      1118    +5     
Impacted Files Coverage Δ
packages/redis/src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa9079...8e7548e. Read the comment docs.

@jaredwray
Copy link
Owner

@alphmth - can you add in a test to check for both scenarios so if we remove it by accident we will see it is missing?

@jaredwray
Copy link
Owner

@alphmth - can you add in or update documentation at https://github.com/jaredwray/keyv/tree/main/packages/redis on the cluster option?

@jaytist
Copy link
Contributor Author

jaytist commented Jul 14, 2022

@jaredwray for test we need to run redis in cluster mode. I tried running redis in cluster mode but it is not working. The mode runs but I am not able to connect from outside. When I researched it says that we need static ip...

@jaredwray jaredwray merged commit 91a5e95 into jaredwray:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants