-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 403 #417
Issue 403 #417
Conversation
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1115 1113 -2
=========================================
- Hits 1115 1113 -2
Continue to review full report at Codecov.
|
@alphmth - I am going to merge the pull request #405 can you update the rest of the packages and testing in this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the dependencies across all of these?
Fixes #404
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
The Keyv.Options type requires a type of Store, but all stores in this library appear to be implementing Store<string | undefined>. If the Value type is anything but string then using this option isn't possible, typescript will complain. This should be expecting a Store<string | undefined>, which also makes sense considering all values are, by default, serialized to string using JSONB before being passed down to the store.
What is the new behavior (if this is a feature change)?
Instead of expecting a Store<string | undefined> , expect Store
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: