Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 403 #417

Merged
merged 25 commits into from
Jul 23, 2022
Merged

Issue 403 #417

merged 25 commits into from
Jul 23, 2022

Conversation

jaytist
Copy link
Contributor

@jaytist jaytist commented Jul 19, 2022

Fixes #404

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • The Keyv.Options type requires a type of Store, but all stores in this library appear to be implementing Store<string | undefined>. If the Value type is anything but string then using this option isn't possible, typescript will complain. This should be expecting a Store<string | undefined>, which also makes sense considering all values are, by default, serialized to string using JSONB before being passed down to the store.

  • What is the new behavior (if this is a feature change)?

  • Instead of expecting a Store<string | undefined> , expect Store

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • No

  • Other information:

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #417 (60b1526) into main (4efe8e0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #417   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1115      1113    -2     
=========================================
- Hits          1115      1113    -2     
Impacted Files Coverage Δ
packages/redis/src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4efe8e0...60b1526. Read the comment docs.

@jaredwray
Copy link
Owner

@alphmth - I am going to merge the pull request #405

can you update the rest of the packages and testing in this pull request?

@jaytist jaytist marked this pull request as ready for review July 20, 2022 17:17
Copy link
Owner

@jaredwray jaredwray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the dependencies across all of these?

packages/etcd/package.json Outdated Show resolved Hide resolved
@jaytist jaytist requested a review from jaredwray July 21, 2022 15:03
@jaredwray jaredwray merged commit 0d22676 into jaredwray:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyv.Options type incorrectly defines store option type
2 participants