Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip compression #457

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Gzip compression #457

merged 5 commits into from
Aug 31, 2022

Conversation

jaytist
Copy link
Contributor

@jaytist jaytist commented Aug 30, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #457 (87e24e6) into main (a3e353b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1103      1103           
=========================================
  Hits          1103      1103           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

packages/keyv/package.json Outdated Show resolved Hide resolved
@jaytist jaytist requested a review from jaredwray August 30, 2022 18:28
Copy link
Owner

@jaredwray jaredwray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also getting this error when running test on it:

  serialize compression

  test/test.js:17

   16:   const json = await serialize({value: 'whatever'});                         
   17:   t.is(json, '{"value":":base64:H4sIAAAAAAAAAyvPSCxJLUstAgCzQxFOCAAAAA=="}');
   18: });                                                                          

  Difference:

  - '{"value":":base64:H4sIAAAAAAAAEyvPSCxJLUstAgCzQxFOCAAAAA=="}'
  + '{"value":":base64:H4sIAAAAAAAAAyvPSCxJLUstAgCzQxFOCAAAAA=="}'

  › test/test.js:17:4

packages/compress-gzip/src/index.d.ts Outdated Show resolved Hide resolved
packages/compress-gzip/src/index.d.ts Outdated Show resolved Hide resolved
packages/compress-gzip/test/test.js Outdated Show resolved Hide resolved
@jaytist jaytist requested a review from jaredwray August 31, 2022 18:40
@jaredwray jaredwray merged commit a478931 into jaredwray:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants