-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed namespace clear issue #501
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 319 319
=========================================
Hits 319 319 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@jaredwray namespace issue for redis is fixed |
@jaredwray please correct me if I'm wrong, but I believe this fix will remove the namespace only when In other words:
Hope above points make sense. |
@kdybicz - the question that we will have is if it is even possible to remove expired members from the namespace key. |
@jaredwray that's my main concern and I suspect it might not be possible. In such case it might make sense to simplify the test, just to make sure that A side question, as I didn't looked that deep into your code: is the namespace always needed? |
going to add this in and then we might want to discuss a better way to handle this in the future where we just dont use namespace. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fixes #455