Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor test-suite to use typescript #652

Merged
merged 7 commits into from
Feb 13, 2023
Merged

refactor test-suite to use typescript #652

merged 7 commits into from
Feb 13, 2023

Conversation

chrisllontop
Copy link
Contributor

@chrisllontop chrisllontop commented Feb 3, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@chrisllontop
Copy link
Contributor Author

@jaredwray please, run the pipeline. I did a package.json update to do a build step before run tests.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (322d948) compared to base (ff427c2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #652   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2341      2375   +34     
  Branches         2        77   +75     
=========================================
+ Hits          2341      2375   +34     
Impacted Files Coverage Δ
packages/test-suite/src/api.ts 100.00% <100.00%> (ø)
packages/test-suite/src/compression.ts 100.00% <100.00%> (ø)
packages/test-suite/src/index.ts 100.00% <100.00%> (ø)
packages/test-suite/src/iterator.ts 100.00% <100.00%> (ø)
packages/test-suite/src/namespace.ts 100.00% <100.00%> (ø)
packages/test-suite/src/official.ts 100.00% <100.00%> (ø)
packages/test-suite/src/values.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray
Copy link
Owner

@christianllv - thanks for putting this together and it is looking great. Can you do the following before we get this merged?

  • Can you add in the index.d.ts location in the package.json so that the types are defined?
  • Can you also add in a script that runs the build before we publish so that we make sure the dist directory is built?

@chrisllontop
Copy link
Contributor Author

Hello @jaredwray,

I added the type property in package.json. About the second point, we have a build script (in the main workspace project) and a specific test-suites package.json.

Can you check please, or should I add the script command in the pipeline?

@jaredwray
Copy link
Owner

Hello @jaredwray,

I added the type property in package.json. About the second point, we have a build script (in the main workspace project) and a specific test-suites package.json.

Can you check please, or should I add the script command in the pipeline?

@christianllv what I am hoping for is something like prepublish so that when we do npm publish command it makes sure to build the dist folder before.

@chrisllontop
Copy link
Contributor Author

@jaredwray I'm using prepare. Please check and let me know.

@jaredwray jaredwray merged commit 8c8ee22 into jaredwray:main Feb 13, 2023
@chrisllontop chrisllontop deleted the feature/test-suite-ts branch February 13, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants