-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor test-suite to use typescript #652
Conversation
@jaredwray please, run the pipeline. I did a package.json update to do a build step before run tests. |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2341 2375 +34
Branches 2 77 +75
=========================================
+ Hits 2341 2375 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@christianllv - thanks for putting this together and it is looking great. Can you do the following before we get this merged?
|
Hello @jaredwray, I added the type property in package.json. About the second point, we have a build script (in the main workspace project) and a specific test-suites package.json. Can you check please, or should I add the script command in the pipeline? |
@christianllv what I am hoping for is something like |
@jaredwray I'm using prepare. Please check and let me know. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)