Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨: add schema support #668

Merged
merged 1 commit into from
Mar 6, 2023
Merged

✨: add schema support #668

merged 1 commit into from
Mar 6, 2023

Conversation

fuergaosi233
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add Schema support for #667

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6a6953d) compared to base (05419dc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #668   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2341      2342    +1     
  Branches         2         2           
=========================================
+ Hits          2341      2342    +1     
Impacted Files Coverage Δ
packages/postgres/src/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray
Copy link
Owner

@fuergaosi233 - Thanks so much for the contribution!!! This overall looks good and ready to submit but was wondering if you could add in a unit test using the schema option with something other than public so it validates that it works.

Let me know if you need help.

@jaredwray
Copy link
Owner

@fuergaosi233 - just following up if you can get a couple updated unit tests in for this new option.

@fuergaosi233
Copy link
Contributor Author

Ok, I'll try that

@jaredwray
Copy link
Owner

@fuergaosi233 great! if you want I can look to add in the code also if you dont have time this week.

@jaredwray jaredwray merged commit 827c2e6 into jaredwray:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants