fix: according to the redis documentation, an iterator must not be co… #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsidered finished unless it returns a cursor value of 0, even if the returned page has no entries
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2405 2404 -1
Branches 122 122
=========================================
- Hits 2405 2404 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@AuspeXeu - thanks so much for the pull request. This will be released in the next couple weeks. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsidered finished unless it returns a cursor value of 0, even if the returned page has no entries
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
According to the redis documentation, an iterator must not be considered finished unless it returns a cursor value of 0, even if the returned page has no entries.