Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring cleanup, pythonic updates, black formatting #169

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Refactoring cleanup, pythonic updates, black formatting #169

merged 2 commits into from
Aug 20, 2024

Conversation

desrod
Copy link
Contributor

@desrod desrod commented May 25, 2024

Just a quick update to garmin.py to use os.path.join(), isort, black and some pythonic constructs. Still working my way through some of the issues around creation of duplicate entries when using --fromdate via the API.

longstone
longstone reviewed Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@longstone longstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the getenv part. Otherwise looks good to me. Thank you.

longstone
longstone reviewed Aug 20, 2024
View reviewed changes
withings_sync/garmin.py Outdated Show resolved Hide resolved
@longstone longstone merged commit 9121456 into jaroslawhartman:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longstone longstone longstone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desrod @longstone