Fix printf funcs on memory pressure with floats #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmopolitan's printf-family functions currently crash if one tries to format a floating point number with a large precision (large enough that gdtoa tries to allocate memory to format the number) when under memory pressure (i.e. when malloc fails), because gdtoa fails to check if malloc fails. The added tests (which would previously crash under cosmopolitan without this patch) show how to reproduce the issue. This patch fixes this, and adds the aforementioned tests.
jart
approved these changes
Sep 1, 2024
| if (limit.rlim_max > 1000000 || limit.rlim_max == RLIM_INFINITY) { | ||
| limit.rlim_max = 1000000; | ||
| limit.rlim_cur = limit.rlim_max; | ||
| ASSERT_GE(setrlimit(RLIMIT_AS, &limit), 0); |
There was a problem hiding this comment.
You truly understand Cosmopolitan Libc if you're using this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmopolitan's printf-family functions currently crash if one tries to
format a floating point number with a large precision (large enough
that gdtoa tries to allocate memory to format the number) when under
memory pressure (i.e. when malloc fails), because gdtoa fails to check
if malloc fails.
The added tests (which would previously crash under cosmopolitan
without this patch) show how to reproduce the issue.
This patch fixes this, and adds the aforementioned tests.