Partially fix printf hex float numbers/%a rounding #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hexadecimal printing of floating-point numbers on cosmopolitan (that is, using the a conversion specifier) currently does not correctly round the result in any rounding mode except for the default one (i.e. FE_NEAREST) This commit fixes this, and adds tests for the change (note that there's still some rounding issues with the a conversion specifier in general in relatively rare cases (that is, without non-default rounding modes), but this author gave up on fixing them after they tried to read the floating point formatting code, and wounded up almost more confused than before).
jart
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thank you for doing this. That floating point code was inherited from Lucent. I wouldn't have been able to implement __fmt() without their help, but their code has always been ugly, and it used to fail a lot more things. Since adopting it, I've made it even uglier by smishing and smashing it into passing more tests. My dream is one day I'll get good enough at floating point code to rewrite it all. But that day is not today.
|
Commit message edited to communicate the improvement rather than the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hexadecimal printing of floating-point numbers on cosmopolitan (that is,
using the a conversion specifier) currently does not correctly round the
result in any rounding mode except for the default one (i.e. FE_NEAREST)
This commit fixes this, and adds tests for the change (note that there's
still some rounding issues with the a conversion specifier in general in
relatively rare cases (that is, without non-default rounding modes), but
this author gave up on fixing them after they tried to read the floating
point formatting code, and wounded up almost more confused than before).