-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDo list #324
Comments
I read I quickly skimmed through the other articles and they seem fine. I like that advanced configuration has been moved to an entirely separate document, this keeps the noise down for new users. I tried recalling how it was when I started using Today I'm pretty set and even pre-compile my Oh and btw TIL about I don't know if this is possible but can Well I've been quiet but still been working on
This allows you to cd into a along with it I also wanted to make
This allows you to Spent more time on writing the message than I intended, so I have to abruptly quit and just send the message and hope for the best. Cheers! |
Can you try https://github.com/jarun/nnn/wiki/Advanced-use-cases#configure-as-default-fm? (Go through it completely.)
You already have |
Do |
Makes sense. I'll do that now. |
Yeah I think I'll try it when I get access to a computer I own...
Haha, now I feel bad. well that makes the |
I have updated the wiki, consolidated the 3 pages into one. |
I can't really tell by looking at the code since the function is huge, is it safe to use The simplest way to fix it is to kill the process when the terminal closes and the simplest way to check that is to see how many hard links point to |
completely.
Which means a |
@KlzXS I went through the issue thread. The problem with the proposed approach is the control never returns to You can still use POSIX threads to spawn a thread and check in it (periodically perhaps?) if the main thread has exited. Though I still believe the solution is stronger than the problem with this approach. you can surely check it out. |
What do you mean? If I detect that my terminal has closed I exit. The parent would then get notified that the child exited and would do whatever it is that it should do. As for the performance issues, I have tried triggering |
Where are you planning to detect it? To elaborate a little: The child is a spawned process/task/script. The parent is |
Let's make sure we are on the same page. You know that:
The way to fix this is to see if the terminal is closed. As all things in Unix, a terminal is a file, in this case it's one of the files in Most terminal utilities seem to have a way of detecting when read and/or write to the terminal and exit, I've tried everything that came to mind. |
Now I see. I never paid attention to the child process not exiting issue and considered REPL programs in a generic way. Yes, I agree we can fix that in |
From the manual of
I guess case |
This case cannot be handled anyway. |
We can't use return of |
... and there's no guarantee it will set and errno it seems from the man. Please raise the PR and let's test it out on systems we have. |
Yes, what I meant was:
EDIT: saw your posts now that I sent this. didn't mean to duplicate your statements... |
I tested on Ubuntu 18.04 and the getch() return thing is unreliable. So @KlzXS I think we should try the blind check without depending on |
The "blind check"? What is that referring to, my mind's all over the place, sorry? |
The way to fix this is to see if the terminal is closed. As all things in Unix, a terminal is a file, in this case it's one of the files in /dev/pts/. While the terminal is open there exists 1 link to it, the filename in /dev/pts/. When it closes the number of links is 0. We can call stat on stdin to see how many links there are. If there are none that means the terminal is closed, we can't get any input from it, so we should exit. |
|
Awesome! Please use that! |
Also. please ensure we have a check for the |
The following patch works for me:
|
Seems good. |
Please add a comment on the check. Please raise the PR. This is an excellent find and fix! I appreciate your effort! |
@0xACE can we have the much awaited Wikipedia page for |
Oh, I right. I will add it to my calender so that I dont forget it again |
I personally like when a file manager is able to tell me something more about my files than "it's a video/image", I don't rely on this, it's just handy to have. But to display this info it uses these program that I didn't have installed by default; I don't know if they come by default on other distros, MacOS or BSDs. So if I need to install a whole program I might as well configure a plugin. It's up to you. |
Most FMs (if not all) use a third-party program to do this as the number of media formats is overwhelming. So yes, you will have to install a new program (or it is a part of a framework like gnome/KDE). AFAIK, mediainfo/exiftool will not be installed by default. And they may not be the natural choice for many users who are accustomed to another utility. So, having the capability through a plugin gives the user that choice. Plugins are indicative and the user can modify it to use his/her preferred utility. @0xACE what do you say? |
Well I think KlzXS put it well:
Lately I have grown keen to tools with "batteries included". But I would understand if Personally I do use the I looked at the related code and it doesn't seem to be cluttered. So if you remove it I see no gain nor loss. I will be happy with whatever you choose. |
You'll have to press The reason I want to remove it is I feel we don't really need it and the user can have the flexibility to choose his own utility to show media info. He can use mediainfo which will be the default in the plugin as well. It's just an extra keypress ( Benefits I see:
How about finding a better utility that shows short and sweet media info (exiftool is shorter than mediainfo) and show that along with file details ( At some point if I get time I might write a simpler media info utility info myself in Python. I don't see any reason why by default mediainfo show show the following data:
For an end user like me, these info doesn't even mean anything. |
Maybe I'll make the plugin show short and sweet info. ;) |
It's rather too detailed. I think a much more concise description would be better. Resolution and format for an image, container, format, resolution, bitrate for video/audio and perhaps some artist metadata if it exists.
Why not remove |
Because we have a nice way to dynamically handle sshfs in |
Okay. So what's the plan, remove |
Right |
Maybe I should have put a bigger emphasis on that. Would you rather we make a custom thing or just feed (formated) output from a 3rd party program? |
For now, I am just calling |
@KlzXS for a shorter and sweeter version can we cleanse and have the following: https://github.com/zmwangx/storyboard/blob/master/src/storyboard/metadata.py It's from a co-dev but I am unable to contact him for sometime. Must be very busy. |
Hehe, I wanted to elude to that, but then I realised the code that has to be maintained for it t work nicely would be too much of an effort considering the effects of portability.
Yeah, when you put it that way, removing
I have to mention: Some quirks I have found with
(I sound like I'm nagging, I would fix these problems myself but atm I'm unavailable for bigger development tasks until late september)
To be honest I really use that information. I"m sort of hosting my own media and I need to know what codecs are being used to know if it will run in a webbrowser or if further encoding/decoding will be needed. It also helps with other metadata that I commonly use. (Another tool i also use is called guessit but it mostly has to do with fetching subtitles) Maybe for a casual user |
I think you can add the following in
Note:
You can add your custom
Without having to store mount info, I think a simpler check would be to see if the dir is empty or not. If it's not empty we can go into the dir. The caveat is, if the dir is not empty (having local files) and the mount fails. The user has no way to know the mount failed.
I am doing what you are doing to reach the config dir. I don't come out of the mount (and use a new context) so I seldom go into that fir manually. :)
User has to provide the name of the remote to mount and unmount. The ssh config is a one time activity. I didn't understand the second part. If you are saying we just select the dir and mount by the dir name, the directory is not created the very first time. Also, that takes the flexibility of being able to mount and unmount on the fly.
In that case let's just have
Indeed. And I'm not picking it up right away either. |
I actually like the output as it is. It's everything I would want to see about a video/audio/image file. |
Yes, I have kept the output intact. |
Yes, you kept The only problem is that compared to |
If it's slower let's just leave it. 2GB is common nowadays. |
@jarun are you frequently using The reason I'm asking is because there has been at least 10 seperate occurrences since I started using nnn where my copy of the repo diverges from Basically everytime I check github I usually pull changes from the repo and this is affecting me. I would like it to stop... I just came in to check on everything and continue my day but instead I'm dealing with a merge conflict. this time I'm dealing with c4ae98a which is now listed as d8fe4b3 |
You could try something like |
@0xACE that's correct. I prefer to keep changes grouped together to keep the history clean. So I keep rebasing which you are noticing. The conflicts may be because of your local changes. Are you planning to make any changes soon? If not, how about rebasing only when you are going to make changes. I think the reason is you are having local changes. How about pushing your changes in a branch in your fork? That way your changes are always available to you and you can merge post each release. Did you try rebasing or merging? When did you rebase last? |
OK, I see. You did rebase in between 2 such changes. I will be more careful in future. However, do expect infrequent encounters. If we keep having separate commits for small changes tracking changes would become an issue. However, now I'll go for bigger commits to avoid this as much as possible. |
The conflicts aren't related to my changes. At first it: my branch was just some small changes, but now it's a huge Currentlly I don't know what the best way to maintain my changes would be, but my next plan is to seperate that And really you can use your git repo as you like, I just wanted to let you know that I'm actually not a fan of github. but maybe I could could push a copy to github in the future |
In that case, just |
Rolled at #329. |
Rolled from #306.
Ready for next release
moclyrics
- show lyrics of the track currently playing in MOCvidthumb
- show video thumbnails in terminalmediainf
- show media info (decoupled as a plugin)dups
- list duplicate files in the current directoryoldbigfile
- list large files by access timemocplay
- now detects if a track is playing or notorganize
- categorize files and move to respective directoriesfzy-edit
merged intofzy-open
checksum
- fixed POSIX compliance issuesboom
plays music in MOC by default-o
to use file access time throughout the program-o
replaces configNNN_RESTRICT_NAV_OPEN
-t
replaces configNNN_NO_AUTOSELECT
-r
replaces configNNN_OPS_PROG
-w
)tar
/bsdtar
always creating tar archives (and not by suffix)-S
.history
file moved tonnn
config directoryProposed features and tasks (up for grabs)
browse()
Anything else which would add value (please discuss in this thread).
List of completed features and tasks.
The text was updated successfully, but these errors were encountered: