-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU using %100 by nnn #225
Comments
Please share the exact steps to reproduce. |
Ohh.. sorry |
I couldn't reproduce your issue. So I need definite steps - how did you start
Also, please try on master and see if you are seeing the issue. |
I use i3-wm, gnome-terminal, vim and manjaro linux than
|
OK.
did you quit vim and nnn or left vim open?
what is it? Used the terminal and closed it directly? Did you quit |
I have tried to reproduce it using your steps and directly closing the terminal (xfce4-terminal) at the points I noted above. However, I do not see the issue. In both the cases Can you try this on the latest release v2.4? |
Please revert back when you have more info. |
Here's a simple way to recreate it I think.
Tried this on two machines with simple terminal and bash. |
I will look into it. |
@cowabungadude69 thanks for the steps. I could reproduce the issue with The issue happens due to the following deadlock:
I have fixed it. Please test and confirm the patch. |
Yep, no problems here. Thank you. |
@cowabungadude69 I believe I have to pull back patch 32dde33 and document as a known issue. The problem with polling on waitpid is whenever a child process is spawned, the parent This is a serious problem. In case of the scenario you reported, the terminal is closed with a nested |
How bad of a fix would it be to spawn a helper process that looks if nnn is still running - but not in TTY-mode anymore - and then kill the main process and itself? |
Some reference to ncdu that I think might have the same issue |
Update: this issue is fixed now!
|
@abdyek @cowabungadude69 @borestad this issue is now fixed. |
Off topic.. but I appreciate watching you fixing problems! Thanks for great work! |
Hi,
I use nnn v2.3 on manjaro linux - i3.
It is running nnn at background when I close it.
https://postimg.cc/s11YZnQ4
The text was updated successfully, but these errors were encountered: