Make modulo operator convert arguments to numbers

jashkenas · Jan 24, 2014 · 1288786 · 1288786
1 parent 2b4421f
commit 1288786
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lib/coffee-script/nodes.js b/lib/coffee-script/nodes.js
diff --git a/src/nodes.coffee b/src/nodes.coffee
@@ -2194,7 +2194,7 @@ UTILITIES =
   "
 
   modulo: -> """
-    function(a, b) { return (a % b + b) % b; }
+    function(a, b) { return (a % b + +b) % b; }
   """
 
   # Shortcuts to speed up the lookup time for native functions.

diff --git a/test/operators.coffee b/test/operators.coffee
@@ -355,3 +355,8 @@ test "modulo operator compound assignment", ->
   a = -2
   a %%= 5
   eq 3, a
+
+test "modulo operator converts arguments to numbers", ->
+  eq 1, 1 %% '42'
+  eq 1, '1' %% 42
+  eq 1, '1' %% '42'