Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: --require options doesn't work for file with illegal chars for JS variable #4209

Closed
ryoqun opened this issue Feb 23, 2016 · 3 comments
Closed

CLI: --require options doesn't work for file with illegal chars for JS variable #4209

ryoqun opened this issue Feb 23, 2016 · 3 comments
Labels
bug

Comments

@ryoqun
Copy link

ryoqun commented Feb 23, 2016

The following snippet tells everything...

$ echo 'console.log "hi"' > /tmp/hello-world.coffee
$ echo 'console.log "hi"' > /tmp/hello_world.coffee
$ coffee -r /tmp/hello_world.coffee -e 'console.log("eval")'
hi
eval
$ coffee -r /tmp/hello-world.coffee -e 'console.log("eval")'
ReferenceError: hello is not defined
@ryoqun ryoqun mentioned this issue Feb 23, 2016
Open
@ryoqun
Copy link
Author

ryoqun commented Feb 23, 2016

By the way, this is causing the bug in the wild: https://github.com/benbria/coffee-coverage/blob/master/register-istanbul.js

This register file can't be required right way....

@ryoqun
Copy link
Author

ryoqun commented Oct 20, 2016

Hooray for new release!!

So, I'm bumping this just to remind others.. :)

@GeoffreyBooth GeoffreyBooth changed the title --require options doesn't work for file with illegal chars for JS variable CLI: --require options doesn't work for file with illegal chars for JS variable May 6, 2017
GeoffreyBooth added a commit to GeoffreyBooth/coffeescript that referenced this issue Aug 23, 2017
@GeoffreyBooth
When using --require, check that the variable we’re creating from the…
dc86121 
… required file/module is a valid identifier name before assigning to it; fixes jashkenas#4209
@GeoffreyBooth GeoffreyBooth mentioned this issue Aug 23, 2017
Merged
GeoffreyBooth added a commit that referenced this issue Aug 23, 2017
@GeoffreyBooth
[CS2] Fix #4209: --require for filenames that are invalid identifiers (…
a3b08e1 
…#4658)

* When using --require, check that the variable we’re creating from the required file/module is a valid identifier name before assigning to it; fixes #4209

* We don’t need no stinkin’ regex
@GeoffreyBooth
Copy link
Collaborator

Fixed by #4658.

@GeoffreyBooth GeoffreyBooth mentioned this issue Sep 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryoqun @GeoffreyBooth