Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4609: support new.target #5106

Merged
merged 2 commits into from
Sep 16, 2018
Merged

Fix #4609: support new.target #5106

merged 2 commits into from
Sep 16, 2018

Conversation

helixbass
Copy link
Collaborator

Fixes #4609

Allow new.target inside functions/methods

Throw an error if new.target is used outside of a function

Throw an error that mimics eg Babel/espree if you try to reference a property other than target on new

@GeoffreyBooth seemed to make sense to target this PR against master? Then I'll add AST support separately

GeoffreyBooth
GeoffreyBooth reviewed Sep 14, 2018
View reviewed changes
src/lexer.coffee Outdated Show resolved Hide resolved
@GeoffreyBooth GeoffreyBooth merged commit 6225627 into jashkenas:master Sep 16, 2018
@helixbass helixbass deleted the new-target branch September 17, 2018 00:36
@helixbass helixbass mentioned this pull request Mar 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helixbass @GeoffreyBooth