MetaProperty AST (new.target) #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helixbass
commented
Mar 16, 2019
| children: ['meta', 'property'] | ||
|
|
||
| checkValid: (o) -> | ||
| if @meta.value is 'new' |
There was a problem hiding this comment.
When reading about MetaProperty, I came across import.meta. So makes sense to make MetaProperty a little bit "generic" so that we can plan on adding other meta-properties
| -> new.something | ||
| ''', ''' | ||
| [stdin]:1:4: error: the only valid meta property for new is new.target | ||
| -> new.something | ||
| ^^^^^^^^^^^^^ | ||
| ''' | ||
|
|
||
| test "`new.target` cannot be assigned", -> |
There was a problem hiding this comment.
Before, it wasn't throwing a compilation error when eg assigning to new.target (since it was just being treated like a normal object-property access)
So this is a benefit of using a separate grammar construct for MetaProperty, since new.target shouldn't be able to be used as an "assignable"
|
Looks good. We should add support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GeoffreyBooth as mentioned in #5169 (comment),
new.targetshould generate aMetaPropertyAST node