Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout not working on Transport.start #55

Closed
mahdianooshah opened this issue Sep 18, 2015 · 1 comment
Closed

timeout not working on Transport.start #55

mahdianooshah opened this issue Sep 18, 2015 · 1 comment

Comments

@mahdianooshah
Copy link

Hi,

I recently noticed that the timeout, set at the time of initializing stomp.Connection(), wouldn't work properly on start method.
For e.g. If I enter the rabbitmq host address to an unreachable address, it takes about a minute to get the exception of type stomp.exception.ConnectFailedException even though I set the timeout to 10.

I just checked the source code and following change seems to solve the issue:
Line 696 of file stomp/transport.py, the code "self.socket.settimeout(self.__timeout)" is probably inside "if need_ssl: " block by mistake and just taking the code out of "if need_ssl" block would solve the issue.

Regards

@jasonrbriggs
Copy link
Owner

Fixed in the next release (4.1.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants