Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for experimental filesystem - fixes jasonroelofs/rice/197 #201

Merged

Conversation

thekendalmiller
Copy link

@thekendalmiller thekendalmiller commented Jan 16, 2024

Fixes #197

This works on Ubuntu 22.04 and Amazon Linux 2.
I believe __has_include was added in c++17

@jasonroelofs
Copy link
Collaborator

A quick search about __has_include and I believe you're right. This looks good, thanks for tracking this down!

@jasonroelofs jasonroelofs merged commit 7ff1ce3 into ruby-rice:master Jan 17, 2024
15 checks passed
@thekendalmiller
Copy link
Author

@jasonroelofs Thanks for the help with this. Is there any ETA of when you'll release the next gem version with this fix?

I haven't been able to get bundler to play nice with a gem installed from git and a gem installed from ruby gems. I am encountering something similar to rubygems/rubygems#5249. The issue description and analysis might be wrong because installation order does work out or rice and mini_portile and similar gems would fail if not. I think It's because one gem is from rubygems and one is from git and bundler/ruby gems puts them in separate locations and the require mkmf-rice fails, presumably because the $LOAD_PATH doesn't include the git sourced gems.

@jasonroelofs
Copy link
Collaborator

Yeah I can cut a release. I'll get something out this weekend.

@jasonroelofs
Copy link
Collaborator

Rice 4.2.1 is out with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: filesystem: No such file or directory
2 participants