Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support systems and installs who use experimental/filesystem includes #200

Closed
wants to merge 1 commit into from

Conversation

jasonroelofs
Copy link
Collaborator

@jasonroelofs
Copy link
Collaborator Author

Hmm, that's a lot of failures. Seems to be a change that only works on Mac right now.

@thekendalmiller
Copy link

thekendalmiller commented Jan 16, 2024

afaict from messing with it this morning and also with your branch, on Ubuntu 22.04, I need to #include <version> or it fails like the github actions are failing.

But it seems <version> was added in c++20 so adding it doesn't help c++17. c++17 will still be broken.

The accepted answer on the stackoverflow is much more complicated. I was trying that but it's failing on c++17. I haven't figure out why yet

@jasonroelofs
Copy link
Collaborator Author

Closing for #201

@jasonroelofs jasonroelofs deleted the experimental-filesystem branch January 17, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: filesystem: No such file or directory
2 participants