-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages with subdirectories and non-elisp files are not handled properly #4
Comments
Yes, this is a big issue. |
gs-elpa
@alem0lars: which version of SLIME do you need? Try 2.0_p20130930 or even 9999 from the |
@alem0lars: see also https://bugs.gentoo.org/show_bug.cgi?id=530148 for SLIME version bump. |
I couldn't find a reference to the Tell me if I'm wrong, but that information is in the recipe not in the repository that hosts the package itself. This is because it's not a package specific thing but a package archiver specific thing. So it shouldn't have nothing to do with the package manager too, which takes an already packaged thing and loads it. So, let's sum up:
Considering only the In the MELPA source code, one interesting file is
(defun pb/expand-source-file-list (dir config)
"Shorthand way to expand paths in DIR for source files listed in CONFIG."
(mapcar 'car (package-build-expand-file-specs dir (pb/config-file-list config))))
(defun pb/checkout-github (name config dir)
"Check package NAME with config CONFIG out of github into DIR."
(let* ((url (format "git://github.com/%s.git" (plist-get config :repo))))
(pb/checkout-git name (plist-put (copy-sequence config) :url url) dir)))
(defun pb/checkout-git (name config dir)
; .... omitted code ...
(pb/run-process nil "git" "clone" repo dir)))
; .... omitted code ...
(apply 'pb/run-process dir "git" "log" "--first-parent" "-n1" "--pretty=format:'\%ci'"
(pb/expand-source-file-list dir config)) What if we just clone the entire repository as it does? |
MELPA is used by The other way to proceed: we can create other ebuild generator, Note, that at the moment
The majority of packages work, as they are pure elisp packages. At least, all that I needed so far worked without any problems. ) |
Ok, it seems package.el just copies all the additional files, so it should be quite easy to fix. I have just tried to install slime with it. I will read package.el code and then do the relevant changes in |
Ok, thanks :) |
@alem0lars: please, check if my last commit to
After it, please, try to emerge |
It seems I am doing the same as |
gs-elpa
Changes commited to the tree as |
I've just installed SLIME. Now the files under |
It copies all the files:
Are you using |
Oh sorry you're right 😄 Thanks a lot for the support 👍 |
Ok, seems to work now. Closing. |
If a specifies in its recipe the files to be installed, some of them seems to be ignored.
For example the SLIME package from melpa specifies:
Which lists the files that should be included.
However when I install the
app-emacs/slime
package I only get these files:In fact, starting emacs with slime now gives me the error:
Could not open load file: lib/hyperspec
.The text was updated successfully, but these errors were encountered: