Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select previously searched term #321

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Select previously searched term #321

wants to merge 3 commits into from

Conversation

Laffini
Copy link

@Laffini Laffini commented Aug 14, 2020

Closes #319

When you press CTRL + F it now selects the previously searched term.

Pieter12345
Pieter12345 reviewed Aug 14, 2020
View reviewed changes
Copy link

@Pieter12345 Pieter12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for creating a PR to implement my feature request.
Second, I did notice that your changes were made using tabs, whereas the sourcecode uses whitespaces. For consistency I recommend changing these to whitespaces as well.

@Laffini
Copy link
Author

Laffini commented Aug 14, 2020

Reworked as per comment.

@Pieter12345
Copy link

Reworked as per comment.

The comment you've added has tab characters as well.

@Laffini
Copy link
Author

Laffini commented Aug 16, 2020

Both lines now use white spaces.

@Laffini Laffini changed the title Select previously selected term Select previously searched term Aug 27, 2020
nbauma109 pushed a commit to nbauma109/jd-gui-duo that referenced this pull request May 11, 2024
added java-decompiler/jd-gui#321
bf0bdec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pieter12345 Pieter12345 Pieter12345 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Select previous search text when pressing "ctrl+f"
2 participants
@Laffini @Pieter12345