Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve warning in Gradle 7.2 #201

Merged

Conversation

KengoTODA
Copy link
Contributor

Hello 👋
Thanks for providing this Gradle plugin, it helps me a lot to keep build scripts simple even with module support. Here I have a suggestion to support Gradle 7.2:

I'm using the gradle-modules-plugin with Gradle 7.2, and found the following warnings during the build:

Execution optimizations have been disabled for task ':jar' to ensure correctness due to the following reasons:
  - Additional action of task ':jar' was implemented by the Java lambda 'org.javamodularity.moduleplugin.tasks.CompileModuleInfoTask$$Lambda$813/0x0000000100832c40'. Reason: Using Java lambdas is not supported as task inputs. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implementation_unknown for more details about this problem.

This issue is similar to #54 but totally new in Gradle 7.2. Official solution for this issue is simply replacing lambdas with anonymous internal Action classes, so I'm suggesting these change.

Thanks for checking this PR!

@KengoTODA
Copy link
Contributor Author

You may refer to the build scan that ensures the test (64f9636) makes build fail.
By replacing lambda with Action, we can stabilize the build.

@siordache siordache merged commit b0130b7 into java9-modularity:master Sep 2, 2021
@siordache
Copy link
Collaborator

Thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants