Merge pull request #32 from javaBin/linkFix

Fixed Link tag
javaBin · Mar 24, 2020 · df2bfa2 · df2bfa2
2 parents 656e888 + 35a885c
commit df2bfa2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/src/components/Link/Link.module.scss b/src/components/Link/Link.module.scss
@@ -11,14 +11,13 @@
     background: none;
     text-align: center;
     cursor: pointer;
-    a {
-        color: $color-logo-red;
-        text-decoration: none;
-    }
+    text-decoration: none; 
+    color: $color-logo-red;
+
     &:hover {
+        text-decoration: none; 
         background: $color-logo-red-dark;
-        a {
-            color: white;
-        }
+        color: white;
+
     }
 }
diff --git a/src/components/Link/Link.tsx b/src/components/Link/Link.tsx
@@ -12,14 +12,16 @@ interface LinkProps {
 function Link(props: LinkProps) {
     return (
         props.external 
-            ? <div className={styles.link}>
-                <a href={props.url} target={props.noBlankTarget ? '' : '_blank'}>{props.children}</a>
-            </div>
-            : <div className={styles.link}>
-                <RouterLink to={props.url}>
+            ?   <a href={props.url} className={styles.link} target={props.noBlankTarget ? '' : '_blank'}>
+                    <span >{props.children}</span>
+                </a>
+            : 
+                <RouterLink to={props.url} className={styles.link}>
+                   <span >
                     {props.children}
+                    </span>
                 </RouterLink>
-            </div>
+
     )
 }