-
Notifications
You must be signed in to change notification settings - Fork 146
WIP: 8206253: Problem with scoll events in window mode #115
base: develop
Are you sure you want to change the base?
Conversation
For the scroll events you must use the x and y points not the absX and absY points. If the application is in fullscreen it works with absX and absY, because then x and absX and y and absY is the same. But when you are in window mode the scene.sceneListener.scrollEvent methods are called with wrong x and y points.
There are a few steps missing before we can consider this PR. Please read CONTRIBUTING.md, specifically the sections about filing a bug, and signing the OCA. Also, please provide a unit test or an evaluation of why a unit test is not possible and what alternative testing is needed. |
I have signed the OCA and mailed it to Oracle. |
OK, we will wait until it has been recorded. As for a test, even for code that is obviously wrong we need some (manual if necessary) set of steps to reproduce the problem before we will accept a patch. |
I have tested this under Linux, but I think it should be the same on Windows:
|
This bug is now in the JBS as JDK-8206253 |
As announced in this message, the official This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed. Once you have done this, it would be helpful to add a comment with a pointer to the new PR. The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this. |
For the scroll events you must use the x and y points not the absX and absY points.
If the application is in fullscreen it works with absX and absY, because then x and absX and y and absY is the same.
But when you are in window mode the scene.sceneListener.scrollEvent methods are called with wrong x and y points.