Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

WIP: JDK-8214158 : (JavaFX) Default to open for document opening on macOS #310

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Tristan971
Copy link
Contributor

@Tristan971 Tristan971 commented Nov 30, 2018

WIP/draft for now, have to ensure a few things first and also a kind of open question down below, but should be the general idea.


Fixes #294. Unsure if the try-catch is needed. I guess it's a light price to pay to ensure (almost) total backwards compatibility in the matter although it is definitely not really needed as macOS environments are much less different from one to the other than Linux ones.

Let me know your thoughts on whether to straight-up replace the previous command or keep this proposed wrapping.

@kevinrushforth kevinrushforth self-requested a review November 30, 2018 21:35
@kevinrushforth kevinrushforth added enhancement New feature or request WIP Work In Progress labels Nov 30, 2018
@kevinrushforth
Copy link
Collaborator

I won't be able to get to this right away. If we go this route, a fallback is probably not necessary.

One thing of note is that the AWT code, which we are currently calling, uses a native method to call LSOpenURLsWithRole rather than "exec"-ing a new process from Java. I'm not sure why (maybe the open command wasn't as robust when it was implemented? Or maybe there is some benefit to using LSOpenURLsWithRole?), but we will need to make sure that there isn't a regression in behavior as a result.

@Tristan971
Copy link
Contributor Author

Yep I have a few concerns about subprocess hierarchy for example like shutting down jvm maybe shutting down browser, I want to do some testing about it beforehand.

@kevinrushforth kevinrushforth removed their request for review February 16, 2019 15:26
@kevinrushforth
Copy link
Collaborator

I removed myself as a reviewer until this is ready for review (currently it is WIP).

@kevinrushforth
Copy link
Collaborator

kevinrushforth commented Oct 1, 2019

As announced in this message, the official jfx repository is moving from hg.openjdk.java.net/openjfx/jfx-dev/rt to github.com/openjdk/jfx.

This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed.

Once you have done this, it would be helpful to add a comment with a pointer to the new PR.


The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK-8214158 : Use Apple's open command to open files on macOS rather than falling back to AWT's Desktop
2 participants