Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple-dot setting button not positioned correctly in Reading View #364

Closed
3 of 7 tasks
sailKiteV opened this issue Mar 13, 2024 · 1 comment · Fixed by #371
Closed
3 of 7 tasks

Triple-dot setting button not positioned correctly in Reading View #364

sailKiteV opened this issue Mar 13, 2024 · 1 comment · Fixed by #371

Comments

@sailKiteV
Copy link

sailKiteV commented Mar 13, 2024

Check for existing bug reports before submitting. #

  • I searched for existing Bug Reports and found no similar reports.

There was a related issue, the solution to which may have accidentally contributed to the behaviour described in this issue: #102

Expected Behaviour #

The triple-dot setting button will be positioned within the overall statblock container, such as:
statblock bug 1-1

Current behaviour #

The triple-dot setting button is positioned relative to the note container or other intervening ancestors with the appropriate position value:
statblock bug 1-2

Reproduction #

  1. Launch Obsidian Sandbox via command Open sandbox vault.
  2. Turn off Restricted mode if require in Settings -> Core plugins.
  3. Install Fantasy Statblocks from the plugin store.
  4. Enable Fantasy Statblocks in Settings -> Core plugins.
  5. Create a new note via preferred method.
  6. Write a statblock codeblock into the note, such as
    ~~~statblock
    creature: Adult Black Dragon
    ~~~
    
  7. View the note in Reading View.

Which Operating Systems are you using? #

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check #

1.5.8 and 1.5.8

Plugin Version #

4.0.9

Confirmation #

  • I have disabled all other plugins and the issue still persists.

Possible solution #

The following CSS is one possible solution to the problem, and was used to produce the image in the Expected Behaviour section:

/* may be worth using .block-language-statblock instead */
.statblock-plugin-parent {
    position: relative;
}
.statblock-plugin-parent .icons:has(> .setting-editor-extra-setting-button) {
    left: var(--size-2-2);
}
@valentine195
Copy link
Member

I think I intentionally put it over there, but I can't recall the exact reason lol

I agree that it looks better closer. I'll try to roll this in with the next update, unless you're willing to PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants