Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧩 Update font awesome dependency's version #445

Open
MrCrackerplays opened this issue May 31, 2024 · 1 comment · May be fixed by #447
Open

🧩 Update font awesome dependency's version #445

MrCrackerplays opened this issue May 31, 2024 · 1 comment · May be fixed by #447

Comments

@MrCrackerplays
Copy link

Scope

I believe the scope would be limited to bumping the versions in package.json.
Checking the versions listed in the package.json to the version list implies it hasn't been bumped in about 4 years.
The main reason I'm asking is because there are a number of free icons listed on the font awesome website that don't show up within the marker icon search. (e.g. house only showing roughly 4 house icons compared to 19 on the website)

Discovery

Presumably only the package.json, I am not aware of there being any breaking changes within the dependencies that would affect code.

Validate

These are the dependencies I've been referring to

        "@fortawesome/fontawesome-svg-core": "^1.2.35",
        "@fortawesome/free-regular-svg-icons": "^5.15.2",
        "@fortawesome/free-solid-svg-icons": "^5.15.1",

which I believe, but not tested, would have to be updated to these

        "@fortawesome/fontawesome-svg-core": "^6.5.2",
        "@fortawesome/free-regular-svg-icons": "^6.5.2",
        "@fortawesome/free-solid-svg-icons": "^6.5.2",
@Iwuaa
Copy link

Iwuaa commented Jun 8, 2024

yeah, this would be great to have more icons to choose from

MrCrackerplays added a commit to MrCrackerplays/obsidian-leaflet that referenced this issue Jun 9, 2024
@MrCrackerplays MrCrackerplays linked a pull request Jun 9, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants