remove explain impl from ReplaceableConstDoubleValueSource

javanna · Sep 21, 2023 · 11796dc · 11796dc
1 parent fdb7253
commit 11796dc
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/.../src/main/java/org/elasticsearch/script/expression/ReplaceableConstDoubleValueSource.java b/.../src/main/java/org/elasticsearch/script/expression/ReplaceableConstDoubleValueSource.java
@@ -38,13 +38,8 @@ public boolean needsScores() {
     }
 
     @Override
-    public Explanation explain(LeafReaderContext ctx, int docId, Explanation scoreExplanation) throws IOException {
-        // TODO where is this explain called? I bet it's never tested, and probably never called.
-        ReplaceableConstDoubleValues fv = specialValues.get(ctx);
-        if (fv.advanceExact(docId)) {
-            return Explanation.match((float) fv.doubleValue(), "ReplaceableConstDoubleValues");
-        }
-        return Explanation.noMatch("ReplaceableConstDoubleValues");
+    public Explanation explain(LeafReaderContext ctx, int docId, Explanation scoreExplanation) {
+        throw new UnsupportedOperationException("explain is not supported for _value and should never be called");
     }
 
     @Override