Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added extra checks and option to save result to SharedPreferences #15

Merged
merged 18 commits into from
Mar 13, 2017
Merged

Added extra checks and option to save result to SharedPreferences #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1c4a864
Update AndroidManifest.xml
jahirfiquitiva Mar 12, 2017
bae8622
Comment not really necessary permission
jahirfiquitiva Mar 12, 2017
a9b14f9
Added checks for Debug apps, use of app in emulators, use of pirate a…
jahirfiquitiva Mar 12, 2017
5d26036
Added option to save license valid value to SharedPreferences.
jahirfiquitiva Mar 12, 2017
3a3918a
Update README
jahirfiquitiva Mar 12, 2017
54a9aeb
Update README.md
jahirfiquitiva Mar 12, 2017
53a3aa2
Update proguard-rules.pro
jahirfiquitiva Mar 12, 2017
39c2c5b
Do not allow use of null values for preference name.
jahirfiquitiva Mar 12, 2017
25843b1
Update README
jahirfiquitiva Mar 12, 2017
5a7e5c2
Update README
jahirfiquitiva Mar 12, 2017
e59877f
Update permission.
jahirfiquitiva Mar 12, 2017
55dd8f3
Update README.
jahirfiquitiva Mar 12, 2017
c578c68
Fix proguard-rules.pro
jahirfiquitiva Mar 12, 2017
9ab0ec8
Attempt to fix license valid even without internet connection.
jahirfiquitiva Mar 12, 2017
eb31008
Another attempt to fix license valid even without internet connection.
jahirfiquitiva Mar 12, 2017
0463321
Added some logs to help recognize the received error.
jahirfiquitiva Mar 12, 2017
ff27741
Added back permission because seems to be the only way for the checke…
jahirfiquitiva Mar 12, 2017
f01a0c6
Update README
jahirfiquitiva Mar 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions library/src/main/java/com/github/javiersantos/piracychecker/LibraryUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
import android.content.pm.PackageInfo;
import android.content.pm.PackageManager;
import android.content.pm.Signature;
import android.net.ConnectivityManager;
import android.net.NetworkInfo;
import android.os.Environment;
import android.support.v7.app.AlertDialog;
import android.util.Base64;
Expand Down Expand Up @@ -144,4 +146,11 @@ static boolean isDebug(Context context) {
return ((context.getApplicationInfo().flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0);
}

static boolean isConnectedToInternet(Context context) {
Copy link
Owner

@javiersantos javiersantos Mar 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConnectivityManager will check if the user has WiFi or data enabled. If LuckyPatcher or any other patcher uses an offline mode, this method will return true because the device is connected to the Internet.

This method doesn't fix the issue reported by @franciscofranco , since the license checker will return "Allow" when the user is connected to the Internet and using a simple bypass by LuckyPatcher (offline mode).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind if I ask you for a suggestion?

ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context
.CONNECTIVITY_SERVICE);
NetworkInfo activeNetwork = cm.getActiveNetworkInfo();
return activeNetwork != null && activeNetwork.isConnectedOrConnecting();
}

}
3 changes: 2 additions & 1 deletion library/src/main/java/com/github/javiersantos/piracychecker/PiracyChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ public void dontAllow(int reason) {
public void applicationError(int errorCode) {
// TODO: Check this, from my personal experience, the license is verified
// TODO: without this permission.
if (errorCode == ERROR_MISSING_PERMISSION) {
if ((errorCode == ERROR_MISSING_PERMISSION) &&
LibraryUtils.isConnectedToInternet(context)) {
doExtraVerification(verifyCallback, true);
} else {
verifyCallback.onError(PiracyCheckerUtils.getCheckerErrorFromCode
Expand Down