Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❇️ Support recently added "should_rename_legacy" in function detect (legacy) #262

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

Ousret
Copy link
Member

@Ousret Ousret commented Jan 29, 2023

Update the legacy "detect" function to match chardet signature.
Also, disregard any new parameters that could be added in the future.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #262 (bb70828) into master (7b75eed) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   89.96%   89.92%   -0.05%     
==========================================
  Files          11       11              
  Lines        1196     1201       +5     
==========================================
+ Hits         1076     1080       +4     
- Misses        120      121       +1     
Impacted Files Coverage Δ
charset_normalizer/legacy.py 89.47% <85.71%> (-3.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Ousret Ousret merged commit b250116 into master Jan 29, 2023
@Ousret Ousret deleted the legacy-support-update branch January 29, 2023 19:39
@Ousret Ousret mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants