-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for emoji==2.0.0 #13
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.54%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for that, it appears it works fine for emoji<2, so the requirement isn't actually needed. Sorry for the hassle |
This reverts commit eea6639.
oh sorry. I reverted the commit relating to requirements.txt changes! 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing, it would be appreciated if you could bump the version of Pilmoji (init.py -> version) to 2.0.2, thank you
Hi,
this PR adds fix needed for emoji lib (==2.0.0) as we discussed in DM.
Also resolves #12