Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for emoji==2.0.0 #13

Merged
merged 4 commits into from
Jul 22, 2022
Merged

fix for emoji==2.0.0 #13

merged 4 commits into from
Jul 22, 2022

Conversation

owocado
Copy link
Contributor

@owocado owocado commented Jul 21, 2022

Hi,

this PR adds fix needed for emoji lib (==2.0.0) as we discussed in DM.

Also resolves #12

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 21, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.54%.

Quality metrics Before After Change
Complexity 6.29 ⭐ 6.17 ⭐ -0.12 👍
Method Length 51.33 ⭐ 52.33 ⭐ 1.00 👎
Working memory 8.82 🙂 9.00 🙂 0.18 👎
Quality 69.49% 🙂 68.95% 🙂 -0.54% 👎
Other metrics Before After Change
Lines 140 141 1
Changed files Quality Before Quality After Quality Change
pilmoji/init.py 98.67% ⭐ 98.67% ⭐ 0.00%
pilmoji/helpers.py 68.13% 🙂 67.60% 🙂 -0.53% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pilmoji/helpers.py getsize 10 🙂 95 🙂 13 😞 54.78% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@jay3332 jay3332 self-requested a review July 21, 2022 14:43
Copy link
Owner

@jay3332 jay3332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay3332
Copy link
Owner

jay3332 commented Jul 21, 2022

sorry for that, it appears it works fine for emoji<2, so the requirement isn't actually needed. Sorry for the hassle

@owocado
Copy link
Contributor Author

owocado commented Jul 21, 2022

oh sorry. I reverted the commit relating to requirements.txt changes! 👍🏼

Copy link
Owner

@jay3332 jay3332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, it would be appreciated if you could bump the version of Pilmoji (init.py -> version) to 2.0.2, thank you

@owocado owocado requested a review from jay3332 July 22, 2022 08:51
@jay3332 jay3332 merged commit cc9c91d into jay3332:2.0 Jul 22, 2022
@owocado owocado deleted the patch-1 branch July 23, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a problem about import Pilmoji
2 participants