clang-tidy: modernize-deprecated-headers (envoyproxy#7626)

Description: Use headers such as `<cstring>` as opposed to `<string.h>`. These headers were marked deprecated in C++11/14 - https://clang.llvm.org/extra/clang-tidy/checks/modernize-deprecated-headers.html Risk Level: Low Testing: existing Docs Changes: N/A Release Notes: N/A Signed-off-by: Derek Argueta <dereka@pinterest.com>
jaychenatr · Jul 18, 2019 · 9f65941 · 9f65941
1 parent aa24d08
commit 9f65941
Show file tree

Hide file tree

Showing 14 changed files with 15 additions and 21 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -19,6 +19,7 @@ WarningsAsErrors: 'abseil-duration-*,
                    bugprone-assert-side-effect,
                    bugprone-unused-raii,
                    bugprone-use-after-move,
+                   modernize-deprecated-headers,
                    modernize-make-shared,
                    modernize-make-unique,
                    modernize-return-braced-init-list,

diff --git a/source/common/network/io_socket_handle_impl.cc b/source/common/network/io_socket_handle_impl.cc
@@ -1,7 +1,6 @@
 #include "common/network/io_socket_handle_impl.h"
 
-#include <errno.h>
-
+#include <cerrno>
 #include <iostream>
 
 #include "envoy/buffer/buffer.h"

diff --git a/source/common/router/config_utility.h b/source/common/router/config_utility.h
@@ -1,7 +1,6 @@
 #pragma once
 
-#include <inttypes.h>
-
+#include <cinttypes>
 #include <regex>
 #include <string>
 #include <vector>

diff --git a/source/common/router/header_parser.cc b/source/common/router/header_parser.cc
@@ -1,7 +1,6 @@
 #include "common/router/header_parser.h"
 
-#include <ctype.h>
-
+#include <cctype>
 #include <memory>
 #include <string>
 

diff --git a/source/common/signal/signal_action.h b/source/common/signal/signal_action.h
@@ -1,9 +1,9 @@
 #pragma once
 
-#include <signal.h>
 #include <unistd.h>
 
 #include <algorithm>
+#include <csignal>
 #include <list>
 
 #include "common/common/non_copyable.h"

diff --git a/source/common/stats/isolated_store_impl.cc b/source/common/stats/isolated_store_impl.cc
@@ -1,8 +1,7 @@
 #include "common/stats/isolated_store_impl.h"
 
-#include <string.h>
-
 #include <algorithm>
+#include <cstring>
 #include <string>
 
 #include "common/common/utility.h"

diff --git a/source/common/stats/isolated_store_impl.h b/source/common/stats/isolated_store_impl.h
@@ -1,8 +1,7 @@
 #pragma once
 
-#include <string.h>
-
 #include <algorithm>
+#include <cstring>
 #include <string>
 
 #include "envoy/stats/stats.h"

diff --git a/source/common/stats/tag_extractor_impl.cc b/source/common/stats/tag_extractor_impl.cc
@@ -1,7 +1,6 @@
 #include "common/stats/tag_extractor_impl.h"
 
-#include <string.h>
-
+#include <cstring>
 #include <string>
 
 #include "envoy/common/exception.h"

diff --git a/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc b/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc
@@ -1,11 +1,11 @@
 #include "extensions/filters/listener/proxy_protocol/proxy_protocol.h"
 
-#include <string.h>
 #include <sys/ioctl.h>
 #include <unistd.h>
 
 #include <algorithm>
 #include <cstdint>
+#include <cstring>
 #include <memory>
 #include <string>
 

diff --git a/source/extensions/filters/network/dubbo_proxy/conn_manager.cc b/source/extensions/filters/network/dubbo_proxy/conn_manager.cc
@@ -1,6 +1,6 @@
 #include "extensions/filters/network/dubbo_proxy/conn_manager.h"
 
-#include <stdint.h>
+#include <cstdint>
 
 #include "envoy/common/exception.h"
 

diff --git a/source/extensions/filters/network/thrift_proxy/metadata.h b/source/extensions/filters/network/thrift_proxy/metadata.h
@@ -1,8 +1,7 @@
 #pragma once
 
-#include <string.h>
-
 #include <algorithm>
+#include <cstring>
 #include <list>
 #include <memory>
 #include <string>

diff --git a/source/server/server.cc b/source/server/server.cc
@@ -1,8 +1,7 @@
 #include "server/server.h"
 
-#include <signal.h>
-
 #include <atomic>
+#include <csignal>
 #include <cstdint>
 #include <functional>
 #include <memory>

diff --git a/test/common/signal/signals_test.cc b/test/common/signal/signals_test.cc
@@ -1,6 +1,7 @@
-#include <signal.h>
 #include <sys/mman.h>
 
+#include <csignal>
+
 #include "common/signal/signal_action.h"
 
 #include "test/test_common/utility.h"

diff --git a/test/integration/tcp_dump.cc b/test/integration/tcp_dump.cc
@@ -1,10 +1,10 @@
 #include "test/integration/tcp_dump.h"
 
-#include <signal.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
+#include <csignal>
 #include <fstream>
 
 #include "common/common/assert.h"