Added PendingShipment request call to this repository #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time in the rate request
|
@sangeetamuthu / @ricaurte thanks for the PR, if you could add some tests for this would be awesome. Let me know if I can be of any assistance. Thanks!! |
| end | ||
|
|
||
|
|
||
| end |
There was a problem hiding this comment.
Seems like quite much extra space, IMHO :)
I think it would be a bit more readable if we'll put a line in between function definition and attr_accessor instead. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it allows to generate label url that can be sent via email